[DH-319] Add support for hidden files in Datahub #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balajialg
changed the title
|
@ryanlovett prefers the other approach of using "jupyter_server_config.json" in values.yaml |
github-actions
bot
added
helm-config
jupyterhub-deployment
and removed
hub: datahub
labels
|
@balajialg This looks good! This will set that for all hubs though -- is that what you want? It does make sense since users still have to choose to view hidden files, even with this setting. |
|
@ryanlovett If users still have to choose to view hidden files then lets go with it? I will merge this PR to staging unless @shaneknapp has any reservations. |
|
@balajialg Sounds good. I think the comment about culling can also be removed. |
|
@ryanlovett Yep, just made a commit |
|
@shaneknapp approved this PR in person. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5825
Yaml linter is happy -
